r342731 - [AST][NFC] Remove a superfluous enum in ObjCMethodDeclBitfields added in r338641

Bruno Ricci via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 06:11:39 PDT 2018


Author: brunoricci
Date: Fri Sep 21 06:11:39 2018
New Revision: 342731

URL: http://llvm.org/viewvc/llvm-project?rev=342731&view=rev
Log:
[AST][NFC] Remove a superfluous enum in ObjCMethodDeclBitfields added in r338641

I originally added this enum to avoid including Basic/IdentifierTable.h
in AST/DeclBase.h. However I did not realise it is already included
transitively by AST/DeclarationName.h. Therefore remove this enum and
explicitly include Basic/IdentifierTable.h


Modified:
    cfe/trunk/include/clang/AST/DeclBase.h

Modified: cfe/trunk/include/clang/AST/DeclBase.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/DeclBase.h?rev=342731&r1=342730&r2=342731&view=diff
==============================================================================
--- cfe/trunk/include/clang/AST/DeclBase.h (original)
+++ cfe/trunk/include/clang/AST/DeclBase.h Fri Sep 21 06:11:39 2018
@@ -16,6 +16,7 @@
 
 #include "clang/AST/AttrIterator.h"
 #include "clang/AST/DeclarationName.h"
+#include "clang/Basic/IdentifierTable.h"
 #include "clang/Basic/LLVM.h"
 #include "clang/Basic/SourceLocation.h"
 #include "clang/Basic/Specifiers.h"
@@ -1558,13 +1559,6 @@ class DeclContext {
   class ObjCMethodDeclBitfields {
     friend class ObjCMethodDecl;
 
-    /// This is needed for the bitwidth of Family below but
-    /// is defined in Basic/IdentifierTable.h which we do not include.
-    /// To avoid mismatches between the two definitions we have
-    /// a static_assert in the ctor of ObjCMethodDecl which checks
-    /// that these two ObjCMethodFamilyBitWidth are equal.
-    enum { ObjCMethodFamilyBitWidth = 4 };
-
     /// For the bits in DeclContextBitfields.
     uint64_t : NumDeclContextBits;
 




More information about the cfe-commits mailing list