[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.
Kristina Brooks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 21 03:25:43 PDT 2018
kristina added a comment.
Does appear to work properly:
cfstring:00000000002AC640 off_2AC640 dq offset __CFConstantStringClassReference
cfstring:00000000002AC640 ; DATA XREF: skipDTD+19D↑o
cfstring:00000000002AC640 ; skipDTD+2F7↑o
cfstring:00000000002AC648 dq offset stru_7B8.st_size
cfstring:00000000002AC650 dq offset dword_0
cfstring:00000000002AC658 dq offset qword_28+4
Though it seems it's best off if the section for it were renamed to something like `.text.cfstring` as it otherwise results in a rather bizarre ELF file layout. I should probably mark the section as constant when building it as well:
[18] cfstring PROGBITS 00000000002a9580 2a9580 007740 00 WA 0 0 8
Repository:
rC Clang
https://reviews.llvm.org/D52344
More information about the cfe-commits
mailing list