[PATCH] D50229: +fp16fml feature for ARM and AArch64

Sjoerd Meijer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 02:37:38 PDT 2018


SjoerdMeijer added a comment.

(I am now picking this up, and will try to progress this patch and also https://reviews.llvm.org/D50179)

> Do you expect that the regression tests will be affected by the TargetParser fixes?

No, and that's exactly the reason why it would be nice to get this in. The tests won't change, they show the expected behaviour, and thus we have a sort of "baseline implementation" while we are working on the new options framework.

And just repeating what I said in the other ticket, this option handling implementation is far from ideal and pretty, it's very easy to agree on that. This is a low maintenance patch, so very easy to keep downstream for us, but it would be useful to have it on trunk too perhaps.

I will add comments and a FIXME that we expect a full reimplementation of it.


Repository:
  rC Clang

https://reviews.llvm.org/D50229





More information about the cfe-commits mailing list