[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 21 02:13:20 PDT 2018


ioeric added a comment.

Could you move the corresponding tests from clangd to sema?



================
Comment at: lib/Sema/SemaCodeComplete.cpp:3063
+CodeCompletionString *
+CodeCompletionResult::CreateCodeCompletionString(ASTContext &Ctx,
+                                                 Preprocessor &PP,
----------------
Could you put this definition before `createCodeCompletionStringForDecl`? I think it should make it easier to see unchanged lines.


Repository:
  rC Clang

https://reviews.llvm.org/D52225





More information about the cfe-commits mailing list