[PATCH] D52308: [Sema][CodeCompletion] Fix return type of C++ destructors in code completion

[Jan Korous via Phabricator via cfe-commits]

jkorous added a comment.

Sorry my bad. You are right, we aren't showing destructors in clangd for normal classes. The case where I noticed is kind of a corner case with template class.

  {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
  ---
  {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"test:///main.cpp","languageId":"cpp","version":1,"text":"template<class T> struct foo {}; template<> struct foo<bool> {}; foo<long>::~"}}}
  ---
  {"jsonrpc":"2.0","id":1,"method":"textDocument/completion","params":{"textDocument":{"uri":"test:///main.cpp"},"position":{"line":0,"character":76}}}



  {
    "detail": "void",
    "filterText": "~foo",
    "insertText": "~foo",
    "insertTextFormat": 1,
    "kind": 2,
    "label": " ~foo()",
    "sortText": "3f2ccccc~foo",
    "textEdit": {
      "newText": "~foo",
      "range": {
        "end": {
          "character": 76,
          "line": 0
        },
        "start": {
          "character": 76,
          "line": 0
        }
      }
    }
  },


Repository:
  rC Clang

https://reviews.llvm.org/D52308