[PATCH] D52292: [Sema][OpenCL] Improve diagnostics for not viable overloadable function candidates

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 20 05:08:43 PDT 2018


Anastasia added inline comments.


================
Comment at: include/clang/Sema/Sema.h:8576
+
+  /// Find and extension in an extension map and return its name
+  template<typename T, typename MapT>
----------------
and extension -> an extension ?


================
Comment at: lib/Sema/Sema.cpp:1856
 
+std::string Sema::getOpenCLExtensionsFromDeclExtMap(FunctionDecl *FD) {
+  if (!OpenCLDeclExtMap.empty())
----------------
Is this function to be used for both `OpenCLDeclExtMap` and `OpenCLTypeExtMap`? If yes, may be we could give it more generic name like 'getOpenCLExtensionsFromExtMap'...


Repository:
  rC Clang

https://reviews.llvm.org/D52292





More information about the cfe-commits mailing list