[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 20 03:08:06 PDT 2018


hans added a comment.

Sorry, I didn't realize we both set off to do this in parallel. I've incorporated your changes into my patch.



================
Comment at: test/Driver/Xarch.c:5
+// RUN: not grep ' "-O3" ' %t.log
+// RUN: grep "argument unused during compilation: '-Xarch_i386 -O3'" %t.log
 // RUN: not %clang -target i386-apple-darwin9 -m32 -Xarch_i386 -o -Xarch_i386 -S %s -S -Xarch_i386 -o 2> %t.log
----------------
compnerd wrote:
> I know that this isn’t your doing, but while you’re here, would you mind replacing the temp files with pipes and grep with FileCheck?
r342636


https://reviews.llvm.org/D52266





More information about the cfe-commits mailing list