[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 19 17:40:19 PDT 2018
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.
In https://reviews.llvm.org/D51901#1239759, @delesley wrote:
> This looks okay to me, but I have not tested it on a large code base to see if it breaks anything.
On our code base (not as large as Google's) there was one true positive and no false positives. At least for templates we should be fine now, since we assume that all type-dependent base classes could have any attribute.
Repository:
rC Clang
https://reviews.llvm.org/D51901
More information about the cfe-commits
mailing list