r342525 - [NFC] Fix uncompilable test cases of ExprMutationAnalyzer.

[David Green via cfe-commits]

Thanks!


That sorted us right out.


Dave



From: Shuai Wang
Sent: 19 September 2018 21:32
To: David Green
Cc: cfe-commits at lists.llvm.org
Subject: Re: r342525 - [NFC] Fix uncompilable test cases of ExprMutationAnalyzer.



On Wed, Sep 19, 2018 at 3:10 AM David Green <David.Green at arm.com<mailto:David.Green at arm.com>> wrote:

Hello!


You have some code in here that looks like

 A operator+(A&&, int) {}


which is a non-void function without a return statement. Any reason to use "{}" and not ";"? You seem to have deliberately changed them, but that causes us some problems downstream. Mind if we change them to A operator+(A&&, int);? or will that cause you problems in other places?

You're right, I don't need to define it, fixed in https://reviews.llvm.org/rC342586
Thanks for pointing it out!


Cheers

Dave

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180919/fa86fd6f/attachment.html>