[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer
Bruno Ricci via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 19 10:03:22 PDT 2018
riccibruno added a comment.
In https://reviews.llvm.org/D52268#1239538, @erichkeane wrote:
> Does this still work with 32 bit hosts? Does PointerIntPair have 3 bits in that case? Is the alignof static_assert valid in that case?
I think it does since Decl is manually over-aligned to 8 bytes. But you are right that the static_assert is probably not needed
here since llvm::PointerIntPair checks that the low bits are available.
> I'm not sure how often this ever gets modified, but it is a touch scary to me that we've already maxed out the size of this struct.
I am not sure either... It was just a quick change I spotted and this is borderline not worth doing. If you think that we ought to keep
some space left I will abandon this revision.
Repository:
rC Clang
https://reviews.llvm.org/D52268
More information about the cfe-commits
mailing list