[PATCH] D51868: [libcxx] Build and test fixes for Windows

[Hamza Sood via Phabricator via cfe-commits]

hamzasood updated this revision to Diff 166124.
hamzasood added a comment.
Herald added a subscriber: christof.

I've added a fix for another related issue: the tests would fail to link if libc++ is built only as a DLL.

The auto-linking doesn't look for a dynamic library unless `_DLL` is defined (which I think is done by passing `/MD` to CL), but the test runner doesn't use CL-style commands. This could either be solved by either manually defining that macro or just disabling auto-linking. The test runner already configures the linker correctly so disabling auto-linking seemed like the simplest option.


https://reviews.llvm.org/D51868

Files:
  CMakeLists.txt
  include/filesystem
  test/std/strings/c.strings/cuchar.pass.cpp
  test/support/test_macros.h
  test/support/verbose_assert.h
  utils/libcxx/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51868.166124.patch
Type: text/x-patch
Size: 4415 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180919/24a47a4e/attachment.bin>