[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 18 19:26:10 PDT 2018


rjmccall added a comment.

In https://reviews.llvm.org/D52200#1239007, @aaronpuchert wrote:

> I think it should be possible to get rid of `self->` in the warning message if we want to, after all `this->` is omitted in C++ as well.


Hmm.  It would be consistent to apply the same rule to both cases, and I don't have any serious concerns about dropping it.  If anything, Objective-C pushes the ivar-decorating convention harder than C++ does, since it's officially blessed in the language.


Repository:
  rC Clang

https://reviews.llvm.org/D52200





More information about the cfe-commits mailing list