[PATCH] D51910: [Modules] Add platform feature to requires clause

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added inline comments.


================
Comment at: docs/Modules.rst:476-477
+
+*platform-environment*
+  A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is available.
 
----------------
rsmith wrote:
> What is the reason to allow these to be combined into a single feature name rather than treating them as two distinct features? (Eg, `requires linux, gnueabi` rather than `requires linux-gnueabi`)?
No specific reason other than the convenience of writing triple like requirements. But thinking more about it, it might make more sense to have it decoupled and written as a combination to avoid confusion. Will update the patch to reflect that. 


https://reviews.llvm.org/D51910