[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 17 06:13:37 PDT 2018


JonasToth marked 5 inline comments as done.
JonasToth added inline comments.


================
Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:71
+  auto Diag =
+      diag(WholeDecl->getBeginLoc(), "make only one declaration per statement");
+
----------------
kbobyrev wrote:
> Maybe it's just me: this doesn't seem like a very clear diagnostic message, probably needs better wording (can't think of anything in particular ATM, though).
I updated the diagnostic to include the number of declared variables. I can reword again, for me its hard to think of something better.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51949





More information about the cfe-commits mailing list