[PATCH] D52083: [clangd] Store OR iterator children in heap

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 17 05:16:30 PDT 2018


ilya-biryukov added a comment.

> Seems like this optimization is not worth (yet?). As soon as we get more proximity paths (and hence more OR iterator children) that might make sense.

WDYT about storing **all** the elements with the minimal doc-id outside the heap? I.e. we can pop **all** elements with the minimum doc-id on 'advance' and iterator creation.
That way we could potentially regain the improvements we've seen in the first version.


https://reviews.llvm.org/D52083





More information about the cfe-commits mailing list