[PATCH] D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 14 23:55:32 PDT 2018
ioeric added a comment.
In https://reviews.llvm.org/D52089#1235777, @malaperle wrote:
> why?
I wanted to get some numbers and update the patch summary, but somehow forgot. Sorry about that and thanks for asking!
The AST matcher pops up in performance profile. Although not the most expensive thing we could optimize, this still brings `indexAST` latency from ~5.3s to ~4.4s for a large TU with big preamble.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
More information about the cfe-commits
mailing list