[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 14 16:49:24 PDT 2018
rsmith added inline comments.
================
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+ return;
+ StringRef Filename = File->getName();
+ if (!FileMatchesDepCriteria(Filename.data(), FileType))
----------------
Should we really be using the (arbitrary) name of the file from the `FileEntry` rather than the name as written? It looks like the corresponding code for `InclusionDirective` uses the name as written instead.
https://reviews.llvm.org/D30882
More information about the cfe-commits
mailing list