[PATCH] D51910: [Modules] Add platform feature to requires clause

[Adrian Prantl via Phabricator via cfe-commits]

aprantl added inline comments.


================
Comment at: docs/Modules.rst:470
+*platform variant*
+  A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``, ``win32``, ``linux``, etc) is available.
 
----------------
aprantl wrote:
> Does this work with platforms+environment combinations, such as the ios simulator on Darwin?
Is `iossimulator` a thing? The triple is called `x86_64-apple-ios-11.2.3-simulator` and the SDK calls itself `iphonesimulator`, so I wonder if this shouldn't be called `ios-simulator` or `iphonesimulator` instead.


https://reviews.llvm.org/D51910