[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check
David CARLIER via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 14 13:54:04 PDT 2018
devnexen added inline comments.
================
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199
+ if (Append)
+ RemainingBufferLen -= 1;
+ if (RemainingBufferLen < ILRawVal)
----------------
MaskRay wrote:
> `RemainingBufferLen` is `uint64_t`. Can the `-= 1` overflow?
That s a good point. I may redo as it was before.
https://reviews.llvm.org/D49722
More information about the cfe-commits
mailing list