[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 14 06:38:41 PDT 2018


JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3126
+  } else {
+    templateParameters = nullptr;//llvm::DINodeArray().get();
+  }
----------------
What's the meaning of this comment? 


================
Comment at: lib/CodeGen/CGDebugInfo.h:654
+                           StringRef &LinkageName,
+                           llvm::MDTuple *&templateParameters,
+                           llvm::DIScope *&VDContext);
----------------
s/templateParameters/TemplateParameters/ (same for the rest of this patch)


Repository:
  rC Clang

https://reviews.llvm.org/D52058





More information about the cfe-commits mailing list