[PATCH] D52083: [clangd] Store OR iterator children in heap

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:128
 
+// Return LHS > RHS.
+auto Compare = [](const std::unique_ptr<Iterator> &LHS,
----------------
ilya-biryukov wrote:
> NIT: use triple-slash comments.
> NIT: LHS > RHS seems to be exactly what's defined by this function. Maybe mention `peek()` to explain how actual comparison works?
To make the second part of the comment clearer: `LHS > RHS` **duplicates** what could be inferred from the function name+body (which is small enough to be readily readable)....


https://reviews.llvm.org/D52083