[PATCH] D51982: [clangd] Introduce PostingList interface

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 13 09:12:32 PDT 2018


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Great!



================
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:11
 #include "Iterator.h"
+#include "PostingList.h"
 #include <algorithm>
----------------
And here


================
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:39
 #include <vector>
+#include "PostingList.h"
 
----------------
Why this dep? Seems circular


================
Comment at: clang-tools-extra/clangd/index/dex/PostingList.h:12
+// which can be characterized by a specific feature (such as fuzzy-find trigram,
+// scope, type or any other Search Token). Posting lists are values for
+// inverted index, which maps search tokens to corresponding posting lists.
----------------
And can be traversed in order using an iterator


https://reviews.llvm.org/D51982





More information about the cfe-commits mailing list