[PATCH] D51333: Diagnose likely typos in include statements

Christy Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 13 08:43:25 PDT 2018


christylee added inline comments.


================
Comment at: lib/Lex/PPDirectives.cpp:1901
+            FilenameLoc,
+            LangOpts.MSVCCompat ? NormalizedPath.c_str() : Filename, false,
+            LookupFrom, LookupFromFile, CurDir,
----------------
rsmith wrote:
> You're passing in `false` for `isAngled` here, and producing a double-quoted replacement below. Is that intentional? I would expect that we would preserve the form of the header-name (quoted or angled) and suggest a replacement with the same form.
My mistake, thanks for catching it!


https://reviews.llvm.org/D51333





More information about the cfe-commits mailing list