[PATCH] D52030: [clangd] Test benchmark if we can build it

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev added a comment.

In https://reviews.llvm.org/D52030#1233395, @kbobyrev wrote:

> In https://reviews.llvm.org/D52030#1233349, @sammccall wrote:
>
> > In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote:
> >
> > > Looks good, thanks!
> > >
> > > While we're here: I'm wondering whether we should also introduce very basic test which would just run `clangd-indexer` since it doesn't depend on benchmarks and would be run on all buildbots.
> >
> >
> > Isn't that this test?
>
>
> Yes, but this test checks both. As mentioned, buildbots don't build benchmarks by default and hence this testcase is not actually run anywhere at the moment.


Sorry, that's wrong. It *is* run on every buildbot at the moment, but `IndexBenchmark` binary doesn't exist on any buildbot IIUC, so the second part of the test is not being run. If you add the dependency on `LLVM_BUILD_BENCHMARKS`, then the whole test would be disabled.+


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52030