[PATCH] D52030: [clangd] Test benchmark if we can build it

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 13 07:16:28 PDT 2018


sammccall added a comment.

In https://reviews.llvm.org/D52030#1233323, @kbobyrev wrote:

> Looks good, thanks!
>
> While we're here: I'm wondering whether we should also introduce very basic test which would just run `clangd-indexer` since it doesn't depend on benchmarks and would be run on all buildbots.


Isn't that this test?

> Also, I was thinking whether we should ask some buildbot owners to enable `LLVM_BUILD_BENCHMARKS`, but it probably makes sense when we have more benchmarks (ideally, across different LLVM parts).

Hmm, I thought that was already the case. Isn't the benchmark stuff only not-built on the windows bots?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52030





More information about the cfe-commits mailing list