[PATCH] D52028: [clangd] Cleanup FuzzyFindRequest filtering limit semantics

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:182
   // when the requested number of items is small.
-  const size_t ItemsToRetrieve = 100 * Req.MaxCandidateCount;
-  auto Root = createLimit(move(QueryIterator), ItemsToRetrieve);
----------------
sammccall wrote:
> wow, this was overflowing!
> I guess harmlessly to... numeric_limits<uint32>::max() - 99 or something? weird.
Oh, yeah, good catch! I thought I had some workaround at some point, but seems that it was lost at some point.


https://reviews.llvm.org/D52028