[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clangd/ClangdServer.cpp:537
   C->CommandLine.push_back("-resource-dir=" + ResourceDir);
+  C->CommandLine.push_back("-Wdeprecated-declarations");
   return std::move(*C);
----------------
kadircet wrote:
> sammccall wrote:
> > as noted above I think we should also have -Wno-error=deprecated-declarations
> > 
> > (do you want all of -Wdeprecated, actually?)
> Yes for the second part and no for the first part. As we saw there are some configs out there that treat some types of deprecation warnings as errors, so we don't want to change that behavior.
Doesn't this cause problems when the build flags are `-Wno-deprecated -Werror` then?
We make this `-Wno-deprecated -Werror -Wdeprecated`, and now all uses of deprecated APIs are errors.

This seems like a common configuration, highly noticeable symptoms, and not what the user wants...


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51747