[PATCH] D51921: [VFS] vfs::directory_iterator yields path and file type instead of full Status

[Kristina Brooks via Phabricator via cfe-commits]

kristina added a comment.

Added inline comments regarding code style and internal/external naming.



================
Comment at: include/clang/Basic/VirtualFileSystem.h:135
+
+public:
+  directory_entry() = default;
----------------
The consistency is mostly related to naming of class members or function args or locals, I think the external APIs should use whatever is most suitable, in this case `path()` and `type()` and `status()` would make sense style wise, I think. Just my two cents in, not insisting on any style comments this time :)


Repository:
  rC Clang

https://reviews.llvm.org/D51921