[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

Manoj Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 12 14:44:54 PDT 2018


manojgupta added a comment.

In https://reviews.llvm.org/D51713#1232497, @srhines wrote:

> In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote:
>
> > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? __gnu_mcount_nc  with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845)
>
>
> I CCed myself on that issue as we are trying to do a better job of supporting code coverage, but I don't think this bug is relevant for this patch.
>
> Unless there are any additional reviews, I will likely submit this patch in a few hours.


Yes, Submitting this patch is totally fine, I just wanted to warn you about the potential issue you may run into with "-pg" and ARM32.


Repository:
  rC Clang

https://reviews.llvm.org/D51713





More information about the cfe-commits mailing list