[PATCH] D51725: Allow un-setting the compilation database path

[Simon Marchi via Phabricator via cfe-commits]

simark added a comment.

In https://reviews.llvm.org/D51725#1232092, @ilya-biryukov wrote:

> Wow, this is getting somewhat complicated.
>
> Have you considered rerunning clangd whenever someone changes an option like that?
>  Would that be much more complicated on your side?
>
> Not opposed to having an option too, just want to be aware of the costs involved on your end.


Since we already support changing the compilation database path at runtime, I don't think it's significantly more complex to support resetting that value to the default of empty/not-used.  If we can restart clangd when the users chooses to use no compilation database path, we might as well just restart it every time the user selects a new compilation database path.

I was assuming that restarting clangd might potentially be significantly more costly than just changing a setting, but maybe I'm wrong.  The point of switching compilation database path is usually to point to a different build that has different flags, so all open files will get reparsed anyway...  And just start clangd isn't particularly heavy.

I'll investigate how difficult it is to make our frontend (Theia <https://github.com/theia-ide/theia>) restart clangd when the user switches compilation database.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51725