[PATCH] D51971: [clangd] Use JSON format in benchmark requests reader

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 12 10:04:06 PDT 2018


kbobyrev updated this revision to Diff 165110.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.

@ilya-biryukov thanks! I was assuming that the `StringRef` constructor parses user-provided string :(

`llvm::json::Array` is used now.


https://reviews.llvm.org/D51971

Files:
  clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
  clang-tools-extra/test/clangd/Inputs/requests.json
  clang-tools-extra/test/clangd/Inputs/requests.log
  clang-tools-extra/test/clangd/index-tools.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51971.165110.patch
Type: text/x-patch
Size: 5802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180912/5dbe45f5/attachment.bin>


More information about the cfe-commits mailing list