[PATCH] D51989: [clangd] dexp tool uses llvm::cl to parse its flags.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 12 09:20:18 PDT 2018


ilya-biryukov added a comment.

A small drive-by comment.

PS it'd be cool to have an interface to cl that does not rely on global state...



================
Comment at: clangd/index/dex/dexp/Dexp.cpp:163
+
+struct {
+  const char *Name;
----------------
Maybe use a named struct?
C++ is powerful, but looks obscure at times...


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51989





More information about the cfe-commits mailing list