[PATCH] D51987: [clangd] Rename global-symbol-builder to clangd-symbol-builder.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 12 08:11:37 PDT 2018


ioeric added a comment.

In https://reviews.llvm.org/D51987#1231990, @ilya-biryukov wrote:

> > You beat it to me, but I thought we didn't use indexer as it could be confused with the actual indexing?
>
> Sorry. Not a big deal, can revert back if needed.
>  Mostly like indexer since it's shorter. Also not very confusing, since we call the thing it produces an "index", so calling it an "indexer" seems fine.
>
> What's the index you're referring to? Building data structures for faster search?


Yes. The current symbol builder produces *symbol table*, which can be easily confused with an index. We might have a different tool that builds the symbol index structure (e.g. serialized dex), which might be a better candidate for the name "indexer".


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51987





More information about the cfe-commits mailing list