[PATCH] D50171: [python] [tests] Update test_code_completion
Michał Górny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 11 13:16:03 PDT 2018
mgorny added a comment.
Apparently the first change changing the completion results is:
commit a408f8d27bfd5bab55c39ef2a6fff6850be4a351
Author: Ilya Biryukov <ibiryukov at google.com>
Date: Tue Apr 24 15:48:53 2018
[CodeComplete] Fix completion at the end of keywords
Summary:
Make completion behave consistently no matter if it is run at the
start, in the middle or at the end of an identifier that happens to
be a keyword or a macro name. Since completion is often ran on
incomplete identifiers, they may turn into keywords by accident.
For example, we should produce same results for all of these
completion points:
// ^ is completion point.
^class
cla^ss
class^
Previously clang produced different results for the last case (as if
the completion point was after a space: `class ^`).
This change also updates some offsets in tests that (unintentionally?)
relied on the old behavior.
Reviewers: sammccall, bkramer, arphaman, aaron.ballman
Reviewed By: sammccall
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D45887
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@330717 91177308-0d34-0410-b5e6-96231b3b80d8
https://reviews.llvm.org/D50171
More information about the cfe-commits
mailing list