[PATCH] D51416: [RTTI] Align rtti types to prevent over-alignment
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 11 13:03:38 PDT 2018
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with one change.
================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2730
llvm::GlobalVariable *GV =
- CGM.CreateOrReplaceCXXRuntimeVariable(Name, Init->getType(), Linkage);
+ CGM.CreateOrReplaceCXXRuntimeVariable(Name, Init->getType(), Linkage, 1);
----------------
Please use getTypeAlignInChars(getContext().CharTy), or something like that, so it's clear where the "1" is coming from.
https://reviews.llvm.org/D51416
More information about the cfe-commits
mailing list