[PATCH] D51847: Print correctly dependency paths on Windows

[Zachary Turner via Phabricator via cfe-commits]

zturner added a comment.

Alright I see it.  The reason I'm asking is because after your change you're now printing `main.o: main.c ../include/lib/test.h`.  But I wonder if you should instead be printing `main.o: main.c ..\include\lib\test.h`.  It seems like paths that we show to the user should be in the native path style.



================
Comment at: lib/Frontend/DependencyFile.cpp:389
                           DependencyOutputFormat OutputFormat) {
+  std::string &NativePath = llvm::sys::path::convert_to_slash(Filename);
   if (OutputFormat == DependencyOutputFormat::NMake) {
----------------
This looks like a dangling reference -- undefined behavior.


https://reviews.llvm.org/D51847