[PATCH] D51090: [clangd] Add index benchmarks

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D51090#1230582, @lebedev.ri wrote:

> In https://reviews.llvm.org/D51090#1230579, @kbobyrev wrote:
>
> > The only problem left is that I'm not sure how to run binary which is not under bin (`IndexBenchmark`) using llvm-lit.
>
>
> But it's a //benchmark//.. What use could be from running it as part of the _tests_?
>  For test-suite (lnt) integration, i'm not sure.


Same as any other binary that isn't itself a test - make sure it works :-)
(Mostly just that it doesn't crash)



================
Comment at: clang-tools-extra/test/clangd/benchmark-dummy.test:1
+# RUN: global-symbol-builder %p/Inputs/BenchmarkSource.cpp -- -I%p/Inputs > %t.index
+# RUN: %clangd-benchmark-dir/IndexBenchmark %t.index %p/Inputs/requests.log
----------------
i'd call this `index-tools.test` - it's a good integration test for global-symbol-builder, better when we add dexp to the test to verify the output.


https://reviews.llvm.org/D51090