[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

LG from my side, @sammccall is not a big fan of options so please wait for his approval too



================
Comment at: clangd/tool/ClangdMain.cpp:174
+    llvm::cl::desc(
+        "Enables suggestion of completion items that needs additional changes. "
+        "Like changing an arrow(->) member access to dot(.) member access."),
----------------
s/needs/need


================
Comment at: clangd/tool/ClangdMain.cpp:180
+    "enable-function-arg-snippets",
+    llvm::cl::desc("Gives snippets for function arguments, when disabled only "
+                   "gives parantheses for the call."),
----------------
Maybe mention code completion in the comment?
Something like:
> When enabled, completion snippets insert full function signatures.
> When disabled, completion snippets insert only parentheses for the call.


================
Comment at: clangd/tool/ClangdMain.cpp:181
+    llvm::cl::desc("Gives snippets for function arguments, when disabled only "
+                   "gives parantheses for the call."),
+    llvm::cl::init(clangd::CodeCompleteOptions().EnableFunctionArgSnippets));
----------------
s/parantheses/parentheses


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51214