[PATCH] D51880: [ASTMatchers] add two matchers for dependent expressions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 13:25:10 PDT 2018


aaron.ballman added a comment.

Missing tests and changes to Registry.cpp for dynamic matchers.

Also, do you want to add `isInstantiationDependent()` at the same time, given the relationship with the other two matchers?



================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:777
 
+/// Matches expressions that are type-dependant because the template type
+/// is not yet instantiated.
----------------
s/dependant/dependent


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:787
+///   }
+/// \endcode
+AST_MATCHER(Expr, isTypeDependent) { return Node.isTypeDependent(); }
----------------
Your example should include the matcher syntax.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:790
+
+/// Matches expression that are value-dependant because they contain a
+/// non-type template parameter.
----------------
s/dependant/dependent


Repository:
  rC Clang

https://reviews.llvm.org/D51880





More information about the cfe-commits mailing list