[PATCH] D51084: Implement -Watomic-implicit-seq-cst

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/Sema/SemaChecking.cpp:10974
+  if (E->IgnoreParenImpCasts()->getType()->isAtomicType())
+    return;
   CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
----------------
jfb wrote:
> rjmccall wrote:
> > Can you explain this one?
> It would produce duplicate warnings of `!`, `&&`, `||`, and condition for `? :`. Bool-like conversion is a special case of implicit conversion, which we already check elsewhere.
I see, makes sense.


Repository:
  rC Clang

https://reviews.llvm.org/D51084