[PATCH] D51852: [clangd] Implement FuzzyFindRequest JSON (de)serialization

Yvan Roux via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 07:50:35 PDT 2018


On Mon, 10 Sep 2018 at 16:36, Kirill Bobyrev via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> kbobyrev added a comment.
>
> In https://reviews.llvm.org/D51852#1228883, @yroux wrote:
>
> > Hi Kirill,
> >
> > This commit broke ARMV8 buildbots, logs are available here:
> >  http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6493/steps/build%20stage%201/logs/stdio
> >
> > Thanks
> > Yvan
>
>
> Hi! Apologies for inconvenience, https://reviews.llvm.org/rL341832 should solve the issue.

build on his way, but the issue is fixed, Index.cpp compiles with a warning now:

[5/100] Building CXX object
tools/clang/tools/extra/clangd/CMakeFiles/clangDaemon.dir/index/Index.cpp.o
/home/buildslave/buildslave/clang-cmake-armv8-quick/llvm/tools/clang/tools/extra/clangd/index/Index.cpp:199:33:
warning: comparison of constant 9223372036854775807 with expression of
type 'const size_t' (aka 'const unsigned int') is always true
[-Wtautological-constant-out-of-range-compare]
  if (Request.MaxCandidateCount <= std::numeric_limits<int64_t>::max())
      ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Thanks for the quick fix.


> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D51852
>
>
>


More information about the cfe-commits mailing list