[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

Jonas Devlieghere via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 07:48:38 PDT 2018


JDevlieghere added inline comments.


================
Comment at: Sema/SemaExpr.cpp:5338
             Context.DependentTy, VK_RValue, RParenLoc);
       } else {
 
----------------
jkorous wrote:
> JDevlieghere wrote:
> > While you're at it you might as well remove the else branch here.
> Sorry, I am not following. Do you mean just refactoring?
> 
> ```
> if a
>   foo
> else
>   bar
> 
> ```
> ->
> ```
> if a
>   foo
> 
> bar
> ```
> 
> Or do you really mean removing the else branch? I don't see how that would be NFC.
Yup, that's what I meant. since we have a return anyway. 


Repository:
  rC Clang

https://reviews.llvm.org/D51488





More information about the cfe-commits mailing list