[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM



================
Comment at: lib/Parse/ParseExprCXX.cpp:1687
     if (Tok.isNot(tok::r_paren)) {
-      if (ParseExpressionList(Exprs, CommaLocs, [&] {
-            QualType PreferredType = Actions.ProduceConstructorSignatureHelp(
-                getCurScope(), TypeRep.get()->getCanonicalTypeInternal(),
-                DS.getEndLoc(), Exprs, T.getOpenLocation());
-            Actions.CodeCompleteExpression(getCurScope(), PreferredType);
-          })) {
+      auto Completer = [&]() {
+        QualType PreferredType = Actions.ProduceConstructorSignatureHelp(
----------------
NIT: inline this last completer.


Repository:
  rC Clang

https://reviews.llvm.org/D51038