[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 10 05:39:14 PDT 2018
ilya-biryukov added inline comments.
================
Comment at: lib/Parse/ParseExprCXX.cpp:2827
if (Tok.isNot(tok::r_paren)) {
+ ParsedType TypeRep =
+ Actions.ActOnTypeName(getCurScope(), DeclaratorInfo).get();
----------------
ilya-biryukov wrote:
> ActOnTypeName is called at a different point now, please move it back into the lambda.
As discussed offline, this actually LG.
It's weird that result of `ActOnTypeName` seems to be only needed for code completion and it's called even when completion is disabled.
However, this was the case before the patch as well
Repository:
rC Clang
https://reviews.llvm.org/D51038
More information about the cfe-commits
mailing list