[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 04:43:41 PDT 2018


JonasToth added a comment.

Unicode works both with python3 and python2 (but seemed to work before too).

Otherwise LG



================
Comment at: clang-tidy/tool/run-clang-tidy.py:169
       failed_files.append(name)
-
-    if is_py2:
----------------
The patch does not apply clean to master because of this part. Could you please recheck that?


================
Comment at: clang-tidy/tool/run-clang-tidy.py:171
+      sys.stdout.write(' '.join(invocation) + '\n' + output.decode('utf-8') + '\n')
       if err:
+        sys.stderr.write(err.decode('utf-8') + '\n')
----------------
please use `len(err)` here instead, python3 does not work.


https://reviews.llvm.org/D51220





More information about the cfe-commits mailing list