[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 03:48:20 PDT 2018


ilya-biryukov added a comment.
ilya-biryukov added inline comments.


================
Comment at: lib/Sema/CodeCompleteConsumer.cpp:622
 
+    case CodeCompletionString::CK_Optional:
+      break;
----------------
This change is really sneaky and unrelated to the rest of the patch. It should definitely be done separately from this patch.

Could you give more details on what fails exactly instead? Can we update the test instead?


Repository:
  rC Clang

https://reviews.llvm.org/D51038





More information about the cfe-commits mailing list