[PATCH] D51802: [clangd] Make advanceTo() faster on Posting Lists

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev updated this revision to Diff 164623.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.

Add a short comment on why calling `lower_bound` is redundant. Also, don't spend extra line on return by inverting the condition.


https://reviews.llvm.org/D51802

Files:
  clang-tools-extra/clangd/index/dex/Iterator.cpp


Index: clang-tools-extra/clangd/index/dex/Iterator.cpp
===================================================================
--- clang-tools-extra/clangd/index/dex/Iterator.cpp
+++ clang-tools-extra/clangd/index/dex/Iterator.cpp
@@ -38,7 +38,10 @@
   /// or higher than the given one.
   void advanceTo(DocID ID) override {
     assert(!reachedEnd() && "DOCUMENT iterator can't advance() at the end.");
-    Index = std::lower_bound(Index, std::end(Documents), ID);
+    // If current ID is beyond requested one, iterator is already in the right
+    // state.
+    if (peek() < ID)
+      Index = std::lower_bound(Index, std::end(Documents), ID);
   }
 
   DocID peek() const override {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51802.164623.patch
Type: text/x-patch
Size: 686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180910/a18708d3/attachment-0001.bin>