[PATCH] D51691: [clangd] NFC: Document URIDistance

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 6 06:05:23 PDT 2018


kbobyrev marked an inline comment as done.
kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/FileDistance.h:89
 public:
+  // Memorizes paths from \p Sources and builds efficient structure for URI
+  // distance computations. \p Sources must contain absolute paths, not URIs.
----------------
sammccall wrote:
> The constructor doesn't do any computation, thus there's nothing to memoize.
> 
> I'd suggest dropping the second sentence here, that's the only noteworthy thing specific to this constructor.
Sorry, did you mean dropping the *first sentence* here? The second one seems to be the one you describe.


https://reviews.llvm.org/D51691





More information about the cfe-commits mailing list