[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

Diogo N. Sampaio via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 6 03:05:57 PDT 2018


dnsampaio added inline comments.


================
Comment at: cfe/trunk/utils/TableGen/NeonEmitter.cpp:2412
 
-  OS << "#define __ai static inline __attribute__((__always_inline__, "
+  OS << "#define __ai static __inline __attribute__((__always_inline__, "
         "__nodebug__))\n\n";
----------------
joerg wrote:
> If you want to change it, at least change it properly to use __inline__.
Sorry, I don't get the suggestion. Do you mean test if it is C89 and use __inline, else, use inline?


Repository:
  rL LLVM

https://reviews.llvm.org/D51683





More information about the cfe-commits mailing list