[PATCH] D51675: [Sema] Store MacroInfo in CodeCompletionResult for macro results.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:847
 
+  /// If the result is RK_Macro, this can store the information about the macro
+  /// definition.
----------------
sammccall wrote:
> Let's not make this maybe/optional: `If the result is RK_Macro, information about the macro definition.`
> There's only one relevant constructor, with only 3 callsites (the two you have, and one in clangd), so we can fix them all.
> 
> One of them statically appears like it could be null sometimes, but dynamically should never be null for macros triggering code complete I think (we may want to add an assert).
As discussed offline, undefined macros do not have MacroInfo, and they can appear in sema results. Added this to comment.


Repository:
  rC Clang

https://reviews.llvm.org/D51675